Refactor getFieldValue to simplify author and editor resolution #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the getFieldValue method in BracketedPattern.java to improve code clarity and maintainability by simplifying the logic for resolving author and editor names.
Changes made:
Removed redundant conditions and unnecessary fallbacks.
Streamlined the handling of auth and pureauth cases for better readability.
Ensured proper resolution of author/editor names without altering functionality.
Closes JabRef#12566.
Mandatory checks
[x] I own the copyright of the code submitted and license it under the MIT license.
[ ] Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user).
[ ] Tests created for changes (if applicable).
[ ] Manually tested changed features in running JabRef (always required).
[ ] Screenshots added in PR description (for UI changes).
[ ] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
[ ] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or submitted a pull request to the documentation repository.