Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to new nest versions 9 #124

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dorinpuscasu25
Copy link

All Submissions:

  • Have you followed the guidelines in our Contributing section?
  • Have you checked to ensure there aren't other open
    Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you linted your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like
    us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Add any extra details about your changes

@codecov-commenter
Copy link

Codecov Report

Merging #124 (3c1c934) into master (44419b9) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #124   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines           54        54           
  Branches         5         5           
=========================================
  Hits            54        54           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44419b9...3c1c934. Read the comment docs.

@srpulga
Copy link

srpulga commented Aug 9, 2022

I need this dependency to update my project! I hope this update comes out soon :D

@parthpatel-simbiotik
Copy link

Please merge it. @SomeBody16 @dhaspden

@srpulga
Copy link

srpulga commented Aug 19, 2022

Please merge!!! @SomeBody16 @dhaspden

@JonasGroenbek
Copy link

@dorinpuscasu25
I think there is a redundant rxjs version
"rxjs": "^6.0.0 || ^7.1.0 || ^7.5.0"
the ^7.1.0 version includes the 7.5.0 as the caret is any version greater than 7.1.0 but less than 8.0.0

@newerton
Copy link

@dhaspden Merge it!

@srpulga
Copy link

srpulga commented Nov 17, 2022

@dhaspden Merge it! Please

@IlliaHreben
Copy link

@dhaspden let's go

@nkusibojoski
Copy link

@dhaspden can you please merge this? We need it ASAP.

@BhupenPal
Copy link

@dhaspden Please merge it

@srpulga
Copy link

srpulga commented Feb 14, 2023

@BhupenPal @nkusibojoski @IlliaHreben @newerton @parthpatel-simbiotik

Guys, what I did to not depend on this package anymore. I imported the module directly into my project, so I don't need to depend on that package anymore. It's literally ctrl c + ctrl v on the files.

@srpulga
Copy link

srpulga commented Feb 14, 2023

If want help, just send me a message!

@newerton
Copy link

@BhupenPal @nkusibojoski @IlliaHreben @newerton @parthpatel-simbiotik

Guys, what I did to not depend on this package anymore. I imported the module directly into my project, so I don't need to depend on that package anymore. It's literally ctrl c + ctrl v on the files.

I've already done that, I'm just here helping people, so that the @SomeBody16 accepts this pull request.

But you're right, we can't depend on 1 repository. If you made the clone, and made the improvements, post the link here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants