Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade app-plaform to prevent accidental plugin builds #624

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

amcgee
Copy link
Member

@amcgee amcgee commented Sep 19, 2024

With previous versions of app-platform there was a plugin build and included in the manifest, even when the app didn't intend to build a plugin. The latest build of the cache cleaner has this issue. This has been fixed in later versions of app platform, so upgrading the dependency here to prevent accidental bundling of an empty plugin with the cache cleaner app.

@amcgee amcgee requested a review from a team as a code owner September 19, 2024 12:28
@amcgee amcgee requested a review from a team as a code owner September 19, 2024 12:29
@dhis2-bot
Copy link
Contributor

🚀 Deployed on https://pr-624--dhis2-cache-cleaner.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify September 19, 2024 12:33 Inactive
@amcgee amcgee merged commit 437a499 into master Sep 19, 2024
8 checks passed
@amcgee amcgee deleted the fix/upgrade-app-platform branch September 19, 2024 12:33
dhis2-bot added a commit that referenced this pull request Sep 29, 2024
## [100.1.16](v100.1.15...v100.1.16) (2024-09-29)

### Bug Fixes

* **translations:** sync translations from transifex (master) ([0ec66b4](0ec66b4))
* upgrade app-plaform to prevent accidental plugin builds ([#624](#624)) ([437a499](437a499))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.1.16 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants