Merge pull request #3 from Agomik/admin-refactoring

SingleLayerTeams with no target squad fix
di-unipi-socc · Oct 25, 2023 · 2157ffc · 2157ffc
2 parents 1f628fe + fae41c3
commit 2157ffc
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/microfreshener/core/analyser/sniffer.py b/microfreshener/core/analyser/sniffer.py
@@ -111,8 +111,9 @@ def snif(self, group: Team)->SingleLayerTeamsSmell:
                 target_node = relationship.target
                 source_squad = self.micro_model.squad_of(source_node)
                 target_squad = self.micro_model.squad_of(target_node)
-                if (isinstance(source_node, Service) and isinstance(target_node, Datastore)
-                        and source_squad != target_squad):
+                if (target_squad is None or
+                    (isinstance(source_node, Service) and isinstance(target_node, Datastore)
+                    and source_squad != target_squad)):
                     smell.addLinkCause(relationship)
         return smell