Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Christiaan Meijer <[email protected]>
  • Loading branch information
Yang and cwmeijer authored Jan 10, 2024
1 parent ca470ff commit 42c6ede
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions dianna/visualization/tabular.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ def plot_tabular(
y: List[str],
x_label: str = "Importance score",
y_label: str = "Features",
num_features: int = None,
show_plot: bool = True,
num_features: Optional[int] = None,
show_plot: Optional[bool] = True,
output_filename: Optional[str] = None,
) -> plt.Figure:
"""Plot feature importance with segments highlighted.
Expand All @@ -21,7 +21,7 @@ def plot_tabular(
y (List[str]): List of feature names
x_label (str): Label for the x-axis
y_label (str): Label or list of labels for the y-axis
num_features (int): Number of top features to display
num_features (Optional[int]): Number of top features to display
show_plot (bool, optional): Shows plot if true (for testing or writing
plots to disk instead).
output_filename (str, optional): Name of the file to save
Expand Down

0 comments on commit 42c6ede

Please sign in to comment.