Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit tests #202

Merged
merged 7 commits into from
Jun 21, 2023
Merged

Fix unit tests #202

merged 7 commits into from
Jun 21, 2023

Conversation

nck-mlcnv
Copy link
Contributor

This pr should fix the the failing tests in the testing workflow. #198

@nck-mlcnv nck-mlcnv linked an issue Apr 18, 2023 that may be closed by this pull request
Copy link
Member

@bigerl bigerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still one failing test that needs to be fixed:
image

In general, the files from the query folder should be indexed in a stable order. Please create another issue to sort them in lexicographical order before further processing.

@nck-mlcnv nck-mlcnv requested a review from bigerl May 15, 2023 19:30
Copy link
Member

@bigerl bigerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. However, the FolderQuerySource should produce a deterministic order.

@bigerl bigerl merged commit 13df048 into develop Jun 21, 2023
2 checks passed
@bigerl bigerl deleted the fix/issue-198/fix-tests branch June 21, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants