Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update result data format #254

Merged
merged 19 commits into from
Jul 26, 2024
Merged

Update result data format #254

merged 19 commits into from
Jul 26, 2024

Conversation

nck-mlcnv
Copy link
Contributor

No description provided.

@nck-mlcnv nck-mlcnv requested a review from bigerl June 13, 2024 13:14
@nck-mlcnv nck-mlcnv self-assigned this Jun 13, 2024
Copy link
Member

@bigerl bigerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻

@nck-mlcnv nck-mlcnv requested a review from bigerl June 14, 2024 14:25
@nck-mlcnv nck-mlcnv changed the title Change integers to infinite precision in result data Update result data format Jun 17, 2024
Copy link
Member

@bigerl bigerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, the changes look good. Please use protege to verify the ontology and to validate an output file with the ontology.

@nck-mlcnv nck-mlcnv requested a review from bigerl June 26, 2024 07:13
Copy link
Member

@bigerl bigerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another batch of change requests

schema/iguana.owl Outdated Show resolved Hide resolved
schema/iguana.owl Outdated Show resolved Hide resolved
schema/iguana.owl Outdated Show resolved Hide resolved
schema/iguana.owl Outdated Show resolved Hide resolved
schema/iguana.owl Outdated Show resolved Hide resolved
schema/iguana.owl Show resolved Hide resolved
@nck-mlcnv nck-mlcnv requested a review from bigerl July 24, 2024 12:45
Copy link
Member

@bigerl bigerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. There is just this one oddity with the prefixes. But nothing serious.

schema/iguana.owx Outdated Show resolved Hide resolved
@nck-mlcnv nck-mlcnv requested a review from bigerl July 24, 2024 17:25
@nck-mlcnv
Copy link
Contributor Author

The failing test can probably be ignored, should be fixed already in another branch👍

@nck-mlcnv nck-mlcnv merged commit 695e5e1 into develop Jul 26, 2024
1 of 2 checks passed
@nck-mlcnv nck-mlcnv deleted the fix/results-format branch July 30, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants