Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add investimental broker #85

Merged
merged 8 commits into from
Jul 9, 2024

Conversation

gabrielgradinaru
Copy link
Contributor

Added

Add Investimental broker

Fixes

Checklist

  • Added relevant changes to README (if applicable)
  • Added relevant test(s)
  • Updated GitVersion file and corresponding version in package.json

Related issue (if applicable)

Fixes #..

@dickwolff
Copy link
Owner

Thanks for the PR! I will take a look at it later this week when I have some time!

Copy link
Owner

@dickwolff dickwolff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. There are a few small things regarding ordering which I would like you to change. The other comments are more about trying to understand how Investimental exports their data and how you are processing it in the code.

Thanks!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/converter.ts Outdated Show resolved Hide resolved
src/converters/investimentalConverter.test.ts Show resolved Hide resolved
src/converters/investimentalConverter.ts Show resolved Hide resolved
src/watcher.ts Outdated Show resolved Hide resolved
@dickwolff dickwolff merged commit 74f78a3 into dickwolff:main Jul 9, 2024
2 checks passed
@dickwolff
Copy link
Owner

Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants