Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prop-types + dependency updates #2

Merged
merged 9 commits into from
Nov 6, 2017
Merged

Prop-types + dependency updates #2

merged 9 commits into from
Nov 6, 2017

Conversation

diegocouto
Copy link
Owner

This is a merge between the pull request #314 and an updated dependencies list in package.json.

@diegocouto diegocouto merged commit 35195ec into master Nov 6, 2017
@StanSarr
Copy link

StanSarr commented Nov 8, 2017

@diegocouto I'm gonna use your Shoutem UI. Is it ok for you bud?
Do you another errors, bugs etc...?

@diegocouto
Copy link
Owner Author

diegocouto commented Nov 8, 2017

Sure, @StanSarr! If you find any other issues with Shoutem UI dependencies that should be updated to work well with React v16, just let me know that I'll update it. 😁

Edit
Regarding the errors, I'm currently using it on a project and it works just fine.

@StanSarr
Copy link

StanSarr commented Nov 9, 2017

Cool thank you. I'll let you know 👍

@dailycommit
Copy link

hey @diegocouto the original shoutem/ui does not work with react v16.0.0
How do I install your version ?
npm install @shoutem/ui#pull/314/head does it work?

@diegocouto
Copy link
Owner Author

Hi, @dailycommit! Yep, unfortunately, it doesn't. 😞

As I've merged the proposed changes on my fork and pushed them to master, you can use it through: npm install diegocouto/ui

@dailycommit
Copy link

Thanks for your help @diegocouto, It seems I'll have to change many codes for diegocouto/ui 🤓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants