Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TypeScript error in PDFDownloadLink component with react-pdf v4 #2887

Closed
wants to merge 1 commit into from
Closed

Conversation

islam-kamel
Copy link

@islam-kamel islam-kamel commented Sep 26, 2024

Fixes #2886

  • Updated PDFDownloadLinkProps to correctly handle the children type, allowing both ReactNode and function types.
  • Ensured compatibility with TypeScript type definitions to eliminate type mismatches.
  • Added necessary type assertions to maintain proper functionality.

Copy link

changeset-bot bot commented Sep 26, 2024

⚠️ No Changeset found

Latest commit: d6f7ec0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@islam-kamel islam-kamel changed the title fix: resolve TypeScript error in PDFDownloadLink component with react-pdf v4 fix: resolve TypeScript error in PDFDownloadLink component with react-pdf v4 closes #2886 Sep 26, 2024
@islam-kamel islam-kamel changed the title fix: resolve TypeScript error in PDFDownloadLink component with react-pdf v4 closes #2886 fix: Fixes #2886 TypeScript error in PDFDownloadLink component with react-pdf v4 Sep 26, 2024
@islam-kamel islam-kamel changed the title fix: Fixes #2886 TypeScript error in PDFDownloadLink component with react-pdf v4 fix: Fixes#2886 TypeScript error in PDFDownloadLink component with react-pdf v4 Sep 26, 2024
@islam-kamel islam-kamel changed the title fix: Fixes#2886 TypeScript error in PDFDownloadLink component with react-pdf v4 fix: Fixes #2886 TypeScript error in PDFDownloadLink component with react-pdf v4 Sep 26, 2024
@islam-kamel islam-kamel changed the title fix: Fixes #2886 TypeScript error in PDFDownloadLink component with react-pdf v4 fix: TypeScript error in PDFDownloadLink component with react-pdf v4 Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript Error in PDFDownloadLink with React-PDF v4
1 participant