Skip to content

Fix missing error information when running embedded migrations. #1993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sorccu wants to merge 1 commit into from
Closed

Fix missing error information when running embedded migrations. #1993

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions diesel_migrations/migrations_macros/src/embed_migrations.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,10 @@ pub fn derive_embed_migrations(input: &syn::DeriveInput) -> quote::Tokens {
fn revert(&self, _conn: &SimpleConnection) -> Result<(), RunMigrationsError> {
unreachable!()
}

fn file_path(&self) -> Option<&Path> {
Some(Path::new(self.version))
Copy link
Member

@weiznich weiznich Mar 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think instead of returning a fake path here, we should fix the formatting to just print the version if the path is not set.

}
}
);

Expand All @@ -69,6 +73,7 @@ pub fn derive_embed_migrations(input: &syn::DeriveInput) -> quote::Tokens {
use self::diesel_migrations::*;
use self::diesel::connection::SimpleConnection;
use std::io;
use std::path::Path;

const ALL_MIGRATIONS: &[&Migration] = &[#(#migrations_expr),*];

Expand Down