Skip to content

Added helpful error message when patch_file is used without patch#2126

Merged
weiznich merged 1 commit intodiesel-rs:masterfrom
runfalk:master
Aug 7, 2019
Merged

Added helpful error message when patch_file is used without patch#2126
weiznich merged 1 commit intodiesel-rs:masterfrom
runfalk:master

Conversation

@runfalk
Copy link
Contributor

@runfalk runfalk commented Jul 23, 2019

Currently diesel print-schema will print not found if patch is not installed and the patch_file argument is used. This bit me as I thought it could not find my patch file (which wasn't the case).

Hopefully this patch helps others in my position.

@sgrif
Copy link
Member

sgrif commented Jul 23, 2019

The change seems fine, but I don't think you should need to reformat all the code underneath it for such a small change.

@runfalk
Copy link
Contributor Author

runfalk commented Jul 24, 2019

There we go. I've made the change less invasive.

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! CI is red due to unrelated failing, I re-approve this.

@weiznich
Copy link
Member

weiznich commented Aug 6, 2019

Could you rebase this PR on top of #2131 to fix the CI?

@runfalk
Copy link
Contributor Author

runfalk commented Aug 6, 2019

It seems like there is still some issues with the CI. I've looked at both the failing Travis and Azure pipelines logs and it seems to be timeouts unrelated to my changes. I've retriggered the build.

@runfalk
Copy link
Contributor Author

runfalk commented Aug 7, 2019

The re-run sems to have fixed Azure, but Travis is still not playing nice. If I look at the failed logs they don't event get to setting up Rust.

@weiznich weiznich merged commit 0cacfa0 into diesel-rs:master Aug 7, 2019
@weiznich
Copy link
Member

weiznich commented Aug 7, 2019

Seems like travis has some issues in the last time regarding to downloading stuff. Hopefully the will fix that soon.
(Anyway no need to wait for this.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants