Backport a set of fixes to 1.4.x#2181
Merged
weiznich merged 19 commits intodiesel-rs:1.4.xfrom Oct 11, 2019
Merged
Conversation
…place all of them
Member
|
I see now that libsqlite-sys 0.16 is released. Maybe we should bump that crate again to 0.16 before the release. Can you do add that to this PR? |
Contributor
Author
|
I've bumped libsqlite3-sys in #2183, will backport that when that one is merged. |
Contributor
Author
|
Are there any other commits suitable for a backport? |
Otherwise the constructor exploits implementation defined behaviour by assuming a specific memory layout which may change in the future
Contributor
Author
Member
|
I've added #2164 to minimize duplicated syn versions (and therefore build time) in complexer projects. |
weiznich
approved these changes
Oct 9, 2019
JohnTitor
approved these changes
Oct 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested in #2148, backport some commits to fix the documentation error. As requested in that commit, the SQLite bump is also included, as are a set of commits to make Diesel compile without warning on 1.38.0