Skip to content

Backport a set of fixes to 1.4.x#2181

Merged
weiznich merged 19 commits intodiesel-rs:1.4.xfrom
helaan:1.4.x
Oct 11, 2019
Merged

Backport a set of fixes to 1.4.x#2181
weiznich merged 19 commits intodiesel-rs:1.4.xfrom
helaan:1.4.x

Conversation

@helaan
Copy link
Contributor

@helaan helaan commented Oct 4, 2019

As requested in #2148, backport some commits to fix the documentation error. As requested in that commit, the SQLite bump is also included, as are a set of commits to make Diesel compile without warning on 1.38.0

@weiznich weiznich requested a review from a team October 4, 2019 20:06
@weiznich
Copy link
Member

weiznich commented Oct 4, 2019

I see now that libsqlite-sys 0.16 is released. Maybe we should bump that crate again to 0.16 before the release. Can you do add that to this PR?

@helaan
Copy link
Contributor Author

helaan commented Oct 5, 2019

I've bumped libsqlite3-sys in #2183, will backport that when that one is merged.

@helaan
Copy link
Contributor Author

helaan commented Oct 8, 2019

Are there any other commits suitable for a backport?

@weiznich
Copy link
Member

weiznich commented Oct 8, 2019

I've just realized that this PR is not #2175 so I've just drop the list from there here 🙈

#2019
#2056
#2108
#2102
#2164

I think #2019, #2056 and #2164 are missing. It would be great to also get them.

weiznich and others added 3 commits October 8, 2019 23:24
Otherwise the constructor exploits implementation defined behaviour by
assuming a specific memory layout which may change in the future
@helaan
Copy link
Contributor Author

helaan commented Oct 8, 2019

I've incorporated #2019 and #2056, however #2164 requires additional work, which I'm not sure are worth it at this point, as Diesel doesn't expose types from syn and users of syn-1.0 libraries can just pull in another version of syn.

@weiznich
Copy link
Member

weiznich commented Oct 9, 2019

I've added #2164 to minimize duplicated syn versions (and therefore build time) in complexer projects.

@weiznich weiznich merged commit bd5c8cf into diesel-rs:1.4.x Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants