Backport changes to 1.4.x#2326
Conversation
It was possible to reach `last_error_message` before we set the client encoding to utf8. If there is some other default client encoding set, this could lead to an corrupted string violating rust gurantees about strings always being utf8. Additionally I've checked the codebase for other occurrences of `from_utf8_unchecked` and added comments there why they are fine. Having a second (or third) look at them would be helpful.
Fixes #2204
tosti007
changed the title
|
97505e0 needs to be removed. That commit does break the build. It was accidentality merged. |
|
Can I suggest you add #2159: Fix formatting error with embedded migrations? It's a bugfix that was merged in September. Commit hash is 78ad40d |
|
That seems to be a reasonable addition. 👍 |
|
Possible other candidates:
Seems like I missed tagging those ones while merging PR's |
|
As #2179 brings in a new feature I would say we do not backport any of those 3 PR's. Patch releases are entirely bugfix releases, so no new features there. |
|
Alright, then I believe no more candidates are left (with the exception of #2299, but that relies on the new features). |
|
I will wait a few more days if any other members of @diesel-rs/contributors have some opinion here and then I will try to do a release. |
|
Merged and released (with minor changes) as 1.4.4 🎉 |
7 participants
As said in #2205 a PR should be made with all the required changes along with the changes labeled "maybe backport", so here it is.
I back ported all commits I deemed right, but the tests don't seem to pass on locally due to unrelated build failures.
Hopefully this helps (as I would like to use uuid 0.8) with a release prior to the milestone!