Implement regex filtering#2515
Merged
weiznich merged 20 commits intodiesel-rs:masterfrom Sep 29, 2020
Merged
Conversation
TaKO8Ki
force-pushed
the
filter-regex
branch
from
d00d932 to
35f176d
Compare
weiznich
reviewed
Sep 24, 2020
TaKO8Ki
commented
Sep 24, 2020
TaKO8Ki
force-pushed
the
filter-regex
branch
2 times, most recently
from
1939ee2 to
448661b
Compare
TaKO8Ki
force-pushed
the
filter-regex
branch
from
448661b to
bcd2290
Compare
weiznich
requested changes
Sep 28, 2020
Member
weiznich
left a comment
weiznich
left a comment
There was a problem hiding this comment.
Please remove whitelist/blacklist completely from diesel-cli. It has been deprecated since 1.3, so diesel_cli 2.0 does not need to support it anymore.
diesel_cli/src/main.rs
Outdated
| .collect::<Result<_, _>>() | ||
| .map_err(|e| format!("invalid argument for table filtering regex: {}", e)); | ||
|
|
||
| if matches.is_present("whitelist") { |
Member
There was a problem hiding this comment.
As already written: whiteliste/blacklist has been deprecated since version 1.3.0 we should completely remove them from the CLI.
Member
Author
There was a problem hiding this comment.
Oh, I misunderstood. I'm going to remove these flags.
TaKO8Ki
force-pushed
the
filter-regex
branch
from
3803900 to
6f3fe60
Compare
Member
Author
|
@weiznich |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #1914 is not completed and has conflicts, I've taken over it.
closes #1911, closes #1914