-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
implement LoadQuery for batch insert statements for sqlite connection #4616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
weiznich
merged 18 commits into
diesel-rs:master
from
bwqr:impl-load-query-for-sqlite-batch-insert
Jun 1, 2025
Merged
Changes from 2 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
eaf21f1
implement `LoadQuery` for `InsertStatement` with `BatchInsert` for `S…
bwqr dd92b09
put LoadQuery implementation behind `returning_clauses_for_sqlite_3_3…
bwqr 2bd74c7
implement RunQueryDsl on batch insert statements with sqlite connecti…
bwqr 18ed4ed
use `LoadIter` as iterator for `LoadQuery` implementation of sqlite's…
bwqr b70cbcf
implement `LoadQuery` for `InsertStatement` with `BatchInsert` for `S…
bwqr 585e5ab
Merge branch 'master' of https://github.com/bwqr/diesel into impl-loa…
bwqr d92b6c6
bump minimal supported Rust version to 1.84.0
bwqr bc80aa7
implement LoadQuery for SqliteBatchInsertWrapper with on conflict clause
bwqr 5834854
implement ExecuteDsl on batch insert statements using on conflict cla…
bwqr 4dc6d23
fix clippy warnings
bwqr 8436523
remove ExecuteDsl implementation for on conflict clause.
bwqr 446af6a
update sqlite/all_about_inserts examples to reflect latest `LoadQuery…
bwqr 8744dd0
early bubble up any errors other than deserialization in transaction …
bwqr 9050d32
add tests related for sqlite related to batch insert with returning c…
bwqr b3def36
remove unnecessary trait bounds, reorganize impl blocks for consistency
bwqr e181641
revert making LoadIter pub(crate) since it is not required anymore
bwqr 2aabce0
run rustfmt on diesel_tests/tests/insert.rs
bwqr 0bc4518
Add changelog entry
weiznich File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to skip the collect here and return the iterator directly?