Skip to content

fix(connect): replace shared URL tokens with one-time grants#1246

Open
src-opn wants to merge 1 commit intodevfrom
task/sec-17
Open

fix(connect): replace shared URL tokens with one-time grants#1246
src-opn wants to merge 1 commit intodevfrom
task/sec-17

Conversation

@src-opn
Copy link
Copy Markdown
Collaborator

@src-opn src-opn commented Mar 31, 2026

Summary

  • replace token-bearing remote connect links with single-use grants for both Den-issued handoffs and shared OpenWork workers
  • redeem grants before storing connection settings, and reject legacy invite links that still embed raw tokens in the URL
  • add a share-modal flow for creating one-time connect links while shifting the default shared access path to owner-scoped redemption

Testing

  • pnpm install
  • pnpm --filter @openwork/app typecheck
  • pnpm --filter openwork-server build && pnpm --filter openwork-server test
  • pnpm --filter @openwork-ee/den-web exec tsc --noEmit
  • pnpm --filter @openwork-ee/den-controller build
  • pnpm install --force && pnpm --filter @openwork/app build
  • pnpm --filter @openwork-ee/den-web build
  • pnpm --filter openwork-server build:bin
  • packaging/docker/dev-up.sh
  • HTTP smoke test for local OpenWork grant issue, exchange, mounted access, and single-use rejection
  • Chrome DevTools MCP: open Share -> Access workspace remotely, create a one-time link, then redeem it in an isolated browser context and verify the app lands on a clean /session URL with the redeemed workspace connection

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 31, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
openwork-app Ready Ready Preview, Comment Mar 31, 2026 0:41am
openwork-den Ready Ready Preview, Comment Mar 31, 2026 0:41am
openwork-den-worker-proxy Ready Ready Preview, Comment Mar 31, 2026 0:41am
openwork-landing Ready Ready Preview, Comment, Open in v0 Mar 31, 2026 0:41am
openwork-share Ready Ready Preview, Comment Mar 31, 2026 0:41am

@github-actions
Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

Prevent live worker credentials from leaking through connect links by redeeming single-use grants for both Den handoffs and shared OpenWork workers. This keeps deep links reusable for the flow while making token issuance happen only after the recipient opens the link.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant