fix(session): ignore stale workspace session loads#1277
Open
benjaminshafii wants to merge 1 commit intodevfrom
Open
fix(session): ignore stale workspace session loads#1277benjaminshafii wants to merge 1 commit intodevfrom
benjaminshafii wants to merge 1 commit intodevfrom
Conversation
New-workspace and workspace-switch flows can fire overlapping session loads while the engine reconnects. We already had a scoped-root guard in session-scope.ts, but the live session store never used it, so an older in-flight load could win last and replace the new workspace sidebar with stale results. Drop session-list responses when the active client changed or the selected workspace root no longer matches the load that produced them. This keeps the post-create workspace view stable until the correct workspace sessions arrive.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
loadSessions()results when the active client changed or the selected workspace root moved before the response came backapps/app/src/app/context/session.tsWhy
The previous attempt focused on Windows path persistence, but your latest report points much more strongly to a race: after restart everything looks fine.
That lines up with the current code path: we already had
shouldApplyScopedSessionLoad()insession-scope.tsand tests for stale loads, butcontext/session.tsnever actually used that guard when applying asession.list()response.So during a workspace create/switch, an older in-flight session load could finish after the new workspace had already become active and then replace the sidebar/session list with stale data. That can make the freshly created workspace look empty until restart.
What changed
apps/app/src/app/context/session.tssession.list()returns, only apply the result if:sessions:load:staledebug event and drop the responseVerification
Ran from
apps/app:pnpm typecheckpnpm test:session-scopeNotes