Skip to content

feat(den): add shared select field#1299

Merged
src-opn merged 2 commits intodifferent-ai:devfrom
terrikramer:feat/den-select
Apr 3, 2026
Merged

feat(den): add shared select field#1299
src-opn merged 2 commits intodifferent-ai:devfrom
terrikramer:feat/den-select

Conversation

@terrikramer
Copy link
Copy Markdown
Contributor

@terrikramer terrikramer commented Apr 3, 2026

Summary

  • add a shared DenSelect primitive for ee/apps/den-web dashboard forms
  • migrate the skill editor visibility field and members invite/edit role fields to use the shared select
  • include before/after screenshots for the updated dashboard flows in ee/apps/den-web/pr/screenshots/den-select/

Why

  • these selects were implemented inline with duplicated native <select> styling
  • a shared field keeps dashboard form controls more consistent and makes future select changes cheaper
  • replacing the browser-native chevron with a Lucide icon lets the select match the style and padding of the shared input/search fields more closely

Issue

  • Closes #

Scope

  • ee/apps/den-web/app/(den)/_components/ui/select.tsx
  • ee/apps/den-web/app/(den)/_components/ui/input.tsx
  • ee/apps/den-web/app/(den)/o/[orgSlug]/dashboard/_components/skill-editor-screen.tsx
  • ee/apps/den-web/app/(den)/o/[orgSlug]/dashboard/_components/manage-members-screen.tsx
  • ee/apps/den-web/pr/screenshots/den-select/*

Out of scope

  • admin panel selects in ee/apps/den-web/components/den-admin-panel.tsx
  • fixing the app's lint script / Next 16 lint compatibility
  • generated ee/apps/den-web/next-env.d.ts churn from local Next runs

Testing

Ran

  • pnpm --filter @openwork-ee/den-web build

Result

  • pass: production build completed successfully
  • pnpm --filter @openwork-ee/den-web lint was not included because the app's current next lint script is failing with the existing Next 16 setup and was intentionally left out of scope for this UI refactor

CI status

  • pass: not run yet
  • code-related failures: none known locally
  • external/env/auth blockers: lint script appears incompatible with the current Next setup in this app

Manual verification

  1. Verified http://localhost:3005/o/org_01kn7rq6yzf6e9ev2qg9h1xb75/dashboard/skill-hubs/skills/new and confirmed the visibility select uses the shared field styling.
  2. Verified http://localhost:3005/o/org_01kn7rq6yzf6e9ev2qg9h1xb75/dashboard/members and confirmed the invite role select uses the shared field styling.
  3. Verified http://localhost:3005/o/org_01kn7rq6yzf6e9ev2qg9h1xb75/dashboard/members edit-member flow and confirmed the role select uses the shared field styling.

Evidence

  • ee/apps/den-web/pr/screenshots/den-select/before-skill-editor-visibility.png
  • ee/apps/den-web/pr/screenshots/den-select/after-skill-editor-visibility.png
  • ee/apps/den-web/pr/screenshots/den-select/before-manage-members-invite-role.png
  • ee/apps/den-web/pr/screenshots/den-select/after-manage-members-invite-role.png
  • ee/apps/den-web/pr/screenshots/den-select/before-manage-members-edit-role.png
  • ee/apps/den-web/pr/screenshots/den-select/after-manage-members-edit-role.png

Risk

  • low: only three dashboard selects were migrated, and they still use native <select> behavior

Rollback

  • revert 87915e18 on top of dev

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
openwork-landing Ready Ready Preview, Comment, Open in v0 Apr 3, 2026 3:43pm

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 3, 2026

@terrikramer is attempting to deploy a commit to the Different AI Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2026

The following comment was made by an LLM, it may be inaccurate:

@src-opn
Copy link
Copy Markdown
Collaborator

src-opn commented Apr 3, 2026

🫡

@src-opn src-opn merged commit 941ebd2 into different-ai:dev Apr 3, 2026
2 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants