fix(app): stabilize empty-session draft updates#1333
Closed
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
Collaborator
Author
|
@src-opn thoughts? It's very hacky but it should resolve the flicker when starting a new chat and typing in the composer |
Member
|
this has been fixed already have you tested head of dev @jcllobet ? |
Collaborator
Author
|
@benjaminshafii not on the latest version, no. It wasn't working for me when I got this issue but it was happening only on the app, not in dev (and bundling it didn't surface it either). Closing PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SessionViewprop object stable inapps/app/src/app/app.tsxand expose reactive fields through getters so composer draft updates only invalidate the props that actually changedprompt, which removes the visible flicker while typing the first message in a fresh sessionapps/app/pr/screenshots/session-empty-state-before-fix.pngandapps/app/pr/screenshots/session-empty-state-after-fix.pngBefore / After
sessionProps()object, so typing into the composer on a brand new session caused the empty-state quickstart panel (What do you want to do?,Work on a CSV,Automate Chrome) to re-render and visibly flicker.SessionViewprops stay stable and onlyprops.promptupdates during typing, so the empty-state panel stays visually steady while the composer continues to update normally.Verification
pnpm typecheckpnpm build:uihttp://localhost:4173/sessionhttp://localhost:60535, opened a brand new session, typed into the composer, and confirmed the empty-state quickstart panel remained mounted while typingNotes
packaging/docker/dev-up.sh, but theshareservice failed to boot (ENOTEMPTY: directory not empty, rmdir '/app/node_modules/.pnpm'), so I completed the UI verification with a local preview build instead.