Skip to content

improved harness via more explicit socket drop so ai is not stuck awaiting the test#1334

Merged
jcllobet merged 1 commit intodevfrom
fix/improved-harness-for-browser-entry
Apr 4, 2026
Merged

improved harness via more explicit socket drop so ai is not stuck awaiting the test#1334
jcllobet merged 1 commit intodevfrom
fix/improved-harness-for-browser-entry

Conversation

@jcllobet
Copy link
Copy Markdown
Collaborator

@jcllobet jcllobet commented Apr 4, 2026

Summary

  • Drop lingering mock server sockets during teardown so test:browser-entry exits cleanly.
  • Document that the test’s internal assistant wait is capped at 12 seconds.

Why

  • The test could appear to pass but still hang under an outer harness timeout.
  • Reviewers and automation need a clear signal for setting a reasonable wrapper timeout.

Scope

  • apps/app/scripts/browser-entry.mjs

Out of scope

  • Changing the test’s behavior or expanding browser-entry coverage.

Testing

Ran

  • pnpm --filter @openwork/app test:browser-entry

Result

  • pass

Manual verification

  1. Run pnpm --filter @openwork/app test:browser-entry.
  2. Confirm the script prints a successful result.
  3. Confirm the process exits promptly instead of lingering after success.

Risk

  • Low; teardown-only change plus a clarifying comment.

Rollback

  • Revert the browser-entry.mjs teardown/socket tracking change.

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Apr 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
openwork-app Ready Ready Preview, Comment Apr 4, 2026 7:03am
openwork-den Ready Ready Preview, Comment Apr 4, 2026 7:03am
openwork-den-worker-proxy Ready Ready Preview, Comment Apr 4, 2026 7:03am
openwork-landing Ready Ready Preview, Comment, Open in v0 Apr 4, 2026 7:03am
openwork-share Ready Ready Preview, Comment Apr 4, 2026 7:03am

@jcllobet jcllobet merged commit 3866938 into dev Apr 4, 2026
16 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 4, 2026

The following comment was made by an LLM, it may be inaccurate:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant