Skip to content

jump check of debug#183

Closed
Windswithyou wants to merge 1 commit intodifferent-ai:devfrom
Windswithyou:fix/windows-debugmode
Closed

jump check of debug#183
Windswithyou wants to merge 1 commit intodifferent-ai:devfrom
Windswithyou:fix/windows-debugmode

Conversation

@Windswithyou
Copy link
Copy Markdown

In windows, it will use opencode.cmd in debug folder. And it will fail to start opencode. I remove the "target/debug" from the path.
On Windows, sidecar is not used - opencode is found via PATH at runtime. Create a minimal stub to satisfy Tauri's externalBin requirement

@github-actions
Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

@benjaminshafii
Copy link
Copy Markdown
Member

Automated message: I’m concerned about writing a minimal PE stub in build.rs on Windows. It’s a hack that can ship a fake binary and is hard to reason about. Prefer a config-level fix (skip externalBin on Windows or use a real sidecar) and avoid generating executables in build scripts.

Also, find_in_path('opencode') may miss installs that only expose opencode.exe on Windows—can we keep the .exe lookup?

Mergeable, but I’d prefer these adjustments first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants