fix: load workspace templates on initial connect#199
fix: load workspace templates on initial connect#199benjaminshafii merged 1 commit intodifferent-ai:devfrom
Conversation
|
The following comment was made by an LLM, it may be inaccurate: |
|
@benjaminshafii @OmarMcAdam Guys sorry for the ping! I’d like to get this merged since it fixes the issue where templates don’t load on restart. It’s a very small change—would you mind doing a quick review so I can get this wrapped up? Thanks! |
|
Automated message: this fix is minimal and matches the parity goal (templates load consistently for local + remote). No security concerns from this change. CI is showing UNSTABLE; please rerun checks or rebase on |
Previously, workspace templates were only loaded when connecting to remote workspaces due to a `workspaceType === "remote"` condition. This caused templates in local workspaces to not appear until a new template was created, which triggered a reload via saveTemplate(). Removed the restriction so loadWorkspaceTemplates() is called for all workspace types when a valid targetRoot exists.
JiahaoZhu11
force-pushed
the
fix/template-initial-loading
branch
from
8605737 to
b7d98be
Compare
All set! I’ve rebased the branch on the latest |
|
done thx @JiahaoZhu11 appreciate |
2 participants
Summary
Problem
Workspace templates were only loaded during
connect()whenworkspaceType === "remote". This caused templates in local workspaces to not appear until a new template was created (which triggered a reload viasaveTemplate()).Solution
Removed the
workspaceType === "remote"restriction so templates load for all workspace types.Test plan
.openwork/templates/