Can be replaced with String.repeat()

Author: Vincent Potucek

lib-extra/src/jdt/java/com/diffplug/spotless/extra/glue/jdt/DefaultJavaElementComparator.java

@@ -347,27 +347,18 @@ public int compare(BodyDeclaration bodyDeclaration1, BodyDeclaration bodyDeclara
 	}
 
 	private static int sortPreservedCategory(int category) {
-		switch (category) {
-		case STATIC_FIELDS_INDEX:
-		case STATIC_INIT_INDEX:
-			return STATIC_FIELDS_INDEX;
-		case FIELDS_INDEX:
-		case INIT_INDEX:
-			return FIELDS_INDEX;
-		default:
-			return category;
-		}
+		return switch (category) {
+			case STATIC_FIELDS_INDEX, STATIC_INIT_INDEX -> STATIC_FIELDS_INDEX;
+			case FIELDS_INDEX, INIT_INDEX -> FIELDS_INDEX;
+			default -> category;
+		};
 	}
 
 	private boolean isSortPreserved(BodyDeclaration bodyDeclaration) {
-		switch (bodyDeclaration.getNodeType()) {
-		case ASTNode.FIELD_DECLARATION:
-		case ASTNode.ENUM_CONSTANT_DECLARATION:
-		case ASTNode.INITIALIZER:
-			return true;
-		default:
-			return false;
-		}
+		return switch (bodyDeclaration.getNodeType()) {
+			case ASTNode.FIELD_DECLARATION, ASTNode.ENUM_CONSTANT_DECLARATION, ASTNode.INITIALIZER -> true;
+			default -> false;
+		};
 	}
 
 	private int preserveRelativeOrder(BodyDeclaration bodyDeclaration1, BodyDeclaration bodyDeclaration2) {

lib-extra/src/main/java/com/diffplug/spotless/extra/GitAttributesLineEndings.java

@@ -300,15 +300,14 @@ public String getEndingFor(File file) {
 		}
 
 		private static String convertEolToLineEnding(String eol, File file) {
-			switch (eol.toLowerCase(Locale.ROOT)) {
-			case "lf":
-				return LineEnding.UNIX.str();
-			case "crlf":
-				return LineEnding.WINDOWS.str();
-			default:
-				LOGGER.warn(".gitattributes file has unspecified eol value: {} for {}, defaulting to platform native", eol, file);
-				return LineEnding.PLATFORM_NATIVE.str();
-			}
+			return switch (eol.toLowerCase(Locale.ROOT)) {
+				case "lf" -> LineEnding.UNIX.str();
+				case "crlf" -> LineEnding.WINDOWS.str();
+				default -> {
+					LOGGER.warn(".gitattributes file has unspecified eol value: {} for {}, defaulting to platform native", eol, file);
+					yield LineEnding.PLATFORM_NATIVE.str();
+				}
+			};
 		}
 
 		private LineEnding findDefaultLineEnding(Config config) {
@@ -335,14 +334,11 @@ private LineEnding findDefaultLineEnding(Config config) {
 
 		/** Creates a LineEnding from an EOL. */
 		private static LineEnding fromEol(EOL eol) {
-			// @formatter:off
-			switch (eol) {
-			case CRLF:    return LineEnding.WINDOWS;
-			case LF:      return LineEnding.UNIX;
-			case NATIVE:  return LineEnding.PLATFORM_NATIVE;
-			default: throw new IllegalArgumentException("Unknown eol " + eol);
-			}
-			// @formatter:on
+			return switch (eol) {
+				case CRLF -> LineEnding.WINDOWS;
+				case LF -> LineEnding.UNIX;
+				case NATIVE -> LineEnding.PLATFORM_NATIVE;
+			};
 		}
 	}
 

lib/src/main/java/com/diffplug/spotless/LineEnding.java

@@ -30,7 +30,6 @@
  * Represents the line endings which should be written by the tool.
  */
 public enum LineEnding {
-	// @formatter:off
 	/** Uses the same line endings as Git, using {@code .gitattributes} and the {@code core.eol} property. */
 	GIT_ATTRIBUTES {
 		/** .gitattributes is path-specific, so you must use {@link LineEnding#createPolicy(File, Supplier)}. */
@@ -57,7 +56,6 @@ public Policy createPolicy() {
     MAC_CLASSIC,
     /** preserve the line ending of the first line (no matter which format) */
     PRESERVE;
-	// @formatter:on
 
 	/** Returns a {@link Policy} appropriate for files which are contained within the given rootFolder. */
 	public Policy createPolicy(File projectDir, Supplier<Iterable<File>> toFormat) {
@@ -80,17 +78,16 @@ public Policy createPolicy(File projectDir, Supplier<Iterable<File>> toFormat) {
 		}
 	}
 
-	// @formatter:off
 	/** Should use {@link #createPolicy(File, Supplier)} instead, but this will work iff its a path-independent LineEnding policy. */
 	public Policy createPolicy() {
-		switch (this) {
-		case PLATFORM_NATIVE:	return _PLATFORM_NATIVE_POLICY;
-		case WINDOWS:			return WINDOWS_POLICY;
-		case UNIX:				return UNIX_POLICY;
-		case MAC_CLASSIC:		return MAC_CLASSIC_POLICY;
-		case PRESERVE:			return PRESERVE_POLICY;
-		default:	throw new UnsupportedOperationException(this + " is a path-specific line ending.");
-		}
+		return switch (this) {
+			case PLATFORM_NATIVE -> _PLATFORM_NATIVE_POLICY;
+			case WINDOWS -> WINDOWS_POLICY;
+			case UNIX -> UNIX_POLICY;
+			case MAC_CLASSIC -> MAC_CLASSIC_POLICY;
+			case PRESERVE -> PRESERVE_POLICY;
+			default -> throw new UnsupportedOperationException(this + " is a path-specific line ending.");
+		};
 	}
 
 	static class ConstantLineEndingPolicy extends NoLambda.EqualityBasedOnSerialization implements Policy {
@@ -123,7 +120,7 @@ public String getEndingFor(File file) {
 
         static String getEndingFor(Reader reader) throws IOException {
             char previousCharacter = 0;
-            char currentCharacter = 0;
+            char currentCharacter;
             int readResult;
             while ((readResult = reader.read()) != -1) {
                 currentCharacter = (char) readResult;
@@ -169,15 +166,14 @@ public static boolean nativeIsWin() {
 
 	/** Returns the standard line ending for this policy. */
 	public String str() {
-		switch (this) {
-		case PLATFORM_NATIVE:	return _PLATFORM_NATIVE;
-		case WINDOWS:			return "\r\n";
-		case UNIX:				return "\n";
-		case MAC_CLASSIC:		return "\r";
-		default:	throw new UnsupportedOperationException(this + " is a path-specific line ending.");
-		}
+		return switch (this) {
+			case PLATFORM_NATIVE -> _PLATFORM_NATIVE;
+			case WINDOWS -> "\r\n";
+			case UNIX -> "\n";
+			case MAC_CLASSIC -> "\r";
+			default -> throw new UnsupportedOperationException(this + " is a path-specific line ending.");
+		};
 	}
-	// @formatter:on
 
 	/** A policy for line endings which can vary based on the specific file being requested. */
 	public interface Policy extends Serializable, NoLambda {