feat: generate SQL table schema from JSON Schemas [1/n] #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now finished and ready for review, but awaiting publishing of new version of Will be stacking other PRs on this, working on #139 |
Squashed commits: [a8267eb] Switch moduleResolution so @digidem/types work [1205a2b] Fixes and add forks [981070a] Add tests and fix accordingly [2dac678] Add tests and fixes [01ac065] add types for brittle [537ff7a] Add project, preset, field schemas [ad186ae] cleanup code and add comments [c23cf09] fix: extract correct schema w/out schemaName param [d8786c8] fix: docId as primary key [36eda92] fix enum type [f0c7eed] Remove db artifact [89468e2] WIP: Generate SQL table schema from JSON Schemas
gmaclennan
force-pushed
the
feat/jsonschema-to-sql-schema
branch
from
981070a
to
4da0146
Compare
gmaclennan
changed the title
achou11
approved these changes
Aug 7, 2023
I think more type tests would be good, but probably make more sense to be end-to-end tests rather than unit-testing just this function. |
TODO: Figure out best way to test types
sethvincent
reviewed
Aug 8, 2023
| @@ -0,0 +1,84 @@ | |||
| // Types generated from brittle readme with chatgpt | |||
|
Merged in #149 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate drizzle-orm SQLite table schemas from Mapeo types & JSONSchemas.
(Currently uses unpublished version of
@mapeo/schemathat exports JSONSchemas with expanded $refs)