feat: don't send core keys or haves to peers without capabilities #390
+738
−625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
gmaclennan
force-pushed
the
feat/core-ownership-capabilities-update-events
branch
2 times, most recently
from
20154f7
to
77aeeff
Compare
gmaclennan
force-pushed
the
feat/core-ownership-capabilities-update-events
branch
from
0b6362a
to
0f4a0d6
Compare
gmaclennan
commented
Aug 8, 2024
| }) | ||
| this.#projectExtension.send(message, peer) | ||
| /** | ||
| * Sends auth core keys to the given peer, skipping any keys that we know the |
There was a problem hiding this comment.
I don't think this skips any keys yet, which is fine, probably a perf optimization for later.
EvanHahn
added a commit
that referenced
this pull request
Aug 16, 2024
We want to call a function once the auth writer core emits its `ready` event. Using `once` lets us clean up the listener once it fires, rather than leaving it around. Extracted from [#390]. [#390]: #390 Co-Authored-By: Gregor MacLennan <[email protected]>
EvanHahn
added a commit
that referenced
this pull request
Aug 23, 2024
We want to call a function once the auth writer core emits its `ready` event. Using `once` lets us clean up the listener once it fires, rather than leaving it around. Extracted from [#390]. [#390]: #390 Co-authored-by: Gregor MacLennan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes how core keys are shared and when "pre-have" messages are shared. "pre-haves" are information about which blocks (data records) a peer has, and they are used to show the user before sync starts how much data there is to sync, but we don't want to leak this data to unauthorized clients.
Currently any peer with the project key can receive keys for all cores in the project, and receive the haves for all cores in the project.
This PR makes the following changes: