feat: only send/receive core keys with permission #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) Our "too many files" config import test fails on case-insensitive file systems, such as macOS by default. Our fixture folder had a bunch of files that would get removed on these file systems. For example, one of `0a` and `0A` would get removed. That meant that there were fewer than 10,001 files (as expected), and the test would fail. We could fix this by renaming the files, but I chose to fix this by re-creating the fixture each time we run the test. That avoids creating a folder with 10,001 files inside, and prevents you from having to run `npm run test:buildConfigs`.
EvanHahn
changed the title
gmaclennan
reviewed
Aug 28, 2024
| * @param {CoreManager} cmToReceive | ||
| * @returns {Promise<void>} | ||
| */ | ||
| async function addWriterCores(cmToAdd, cmToReceive) { |
There was a problem hiding this comment.
nit @EvanHahn the naming is slightly confusing, because this is actually adding the cores "owned" by one instance to another instance, but as "read" cores, not writer cores. But I'm not sure what a better naming would be.
EvanHahn
added a commit
that referenced
this pull request
Aug 28, 2024
This is just a simple rename for clarity. See [this comment][0]. [0]: #783 (review)
gmaclennan
pushed a commit
that referenced
this pull request
Aug 29, 2024
This is just a simple rename for clarity. See [this comment][0]. [0]: #783 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly addresses #268.