Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add remoteDetectionAlert dataType #805

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

tomasciccola
Copy link
Contributor

@tomasciccola tomasciccola commented Sep 2, 2024

this installs a local version of mapeo-schema with remoteDetectionAlert schema.

should close #806

Copy link
Contributor

@EvanHahn EvanHahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once we (1) release a new @mapeo/schema (2) fix the type errors.

Could also be good to add a test that runs a remoteDetectionAlert through the whole system to make sure it works. Maybe just create one and make sure we can read it.

@tomasciccola
Copy link
Contributor Author

I'm getting a type error on the test-e2e/project-crud.js, where I added a fixture for remoteDetectionAlert. I don't know why it expects its field metadata to have a manualLocation. Its basically confusing it with an observation. I can add that field to please the type checker since metadata in remoteDetectionAlert allows for any value for any string key, but it feels finicky.

On the other hand, I can't npm i now, because mapeo/schema is a peerDependency in mock-data so the local version installed in this PR doesn't match the version on mock-data...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's time for us to make a new migration!

I think we plan to add this to a version of @mapeo/core that the MVP doesn't depend on--something like v1.1.0. Given that, I think we'll need a new migration here.

@EvanHahn
Copy link
Contributor

Now that we've released @comapeo/[email protected], I think we can revisit this.

@awana-lockfile-bot
Copy link

package-lock.json changes

Click to toggle table visibility
Name Status Previous Current
@comapeo/geometry ADDED - 1.0.1
@mapeo/schema ADDED - 3.0.0-next.28
protobufjs UPDATED 7.2.5 7.4.0

@awana-lockfile-bot
Copy link

package-lock.json changes

Click to toggle table visibility
Name Status Previous Current
@comapeo/geometry ADDED - 1.0.1
@mapeo/schema ADDED - 3.0.0-next.28
protobufjs UPDATED 7.2.5 7.4.0

@awana-lockfile-bot
Copy link

package-lock.json changes

Click to toggle table visibility
Name Status Previous Current
@comapeo/geometry ADDED - 1.0.1
@mapeo/schema ADDED - 3.0.0-next.28
protobufjs UPDATED 7.2.5 7.4.0

@tomasciccola
Copy link
Contributor Author

tomasciccola commented Sep 26, 2024

@EvanHahn I'm having a couple of type errors on test-e2e/project-crud.js which I'm not sure how to interpret...

Also, the awana-lockfile-bot is showing a package-lock change with @mapeo/schema. I think we still have transitive dependencies on mock-data to mapeo/schema, could the type error be related to that (I don't think though...)

@awana-lockfile-bot
Copy link

package-lock.json changes

Click to toggle table visibility
Name Status Previous Current
@comapeo/geometry ADDED - 1.0.1
@mapeo/schema ADDED - 3.0.0-next.28
protobufjs UPDATED 7.2.5 7.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add alerts data type
2 participants