-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add remoteDetectionAlert
dataType
#805
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once we (1) release a new @mapeo/schema
(2) fix the type errors.
Could also be good to add a test that runs a remoteDetectionAlert
through the whole system to make sure it works. Maybe just create one and make sure we can read it.
I'm getting a type error on the On the other hand, I can't |
…ddRemoteDetectionAlertDataType
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's time for us to make a new migration!
I think we plan to add this to a version of @mapeo/core
that the MVP doesn't depend on--something like v1.1.0. Given that, I think we'll need a new migration here.
Now that we've released |
…emoteDetectionAlertDataType
@EvanHahn I'm having a couple of type errors on Also, the awana-lockfile-bot is showing a package-lock change with |
…emoteDetectionAlertDataType
this installs a local version of mapeo-schema with
remoteDetectionAlert
schema.should close #806