Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: auto commit and push documentation #815

Merged
merged 4 commits into from
Sep 19, 2024
Merged

fix: auto commit and push documentation #815

merged 4 commits into from
Sep 19, 2024

Conversation

tomasciccola
Copy link
Contributor

@tomasciccola tomasciccola commented Sep 10, 2024

To allow publishing the docs site, there's two paths:

  1. add push_options: --force on publish flow after allowing force push on main
  2. generate a PAT (Personal access token) and pass the token to the checkout action step

I went with the first option since it seemed more straight away.

Options for this were grabbed from here

I think that the only way to try if this works is to merge to main, since main is actually the protected branch. I had to enable force push on that branch from settings, so with enabling that, this should just work

should fix #707

@EvanHahn
Copy link
Contributor

Planning to review this next week.

@EvanHahn
Copy link
Contributor

I might not get to this today, apologies.

Copy link
Contributor

@EvanHahn EvanHahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I assume this happens before the actual release, right? Like, this happens as part of the "[OPTIC-RELEASE-AUTOMATION] release/1.2.3" PRs?

@tomasciccola
Copy link
Contributor Author

LGTM.

I assume this happens before the actual release, right? Like, this happens as part of the "[OPTIC-RELEASE-AUTOMATION] release/1.2.3" PRs?

85% sure (I know you can see a preview of the deploy on the PR itself, which is an indication of this?)

@tomasciccola tomasciccola merged commit 521adcf into main Sep 19, 2024
7 checks passed
@tomasciccola tomasciccola deleted the fix/pushDocs branch September 19, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix doc auto-commit error when releasing
2 participants