Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix race condition if multiple invites are sent #863

Merged
merged 2 commits into from
Sep 26, 2024

Commits on Sep 24, 2024

  1. test: fix race condition if multiple invites are sent

    We have a test helper, `invite`, that invites people to projects. It
    works like this:
    
    1. Tell the invitee(s) to accept any invite they receive.
    2. Send the invite.
    
    This is fine for most of our tests, where only one invite will be sent
    to each manager. But we have [at least one test][0] where multiple
    invites are sent.
    
    That can cause a race condition. Imagine the following scenario where
    `invite` is called twice:
    
    1. Tell the invitee to accept any invite they receive (listener 1).
    2. Tell the invitee to accept any invite they receive (listener 2).
    3. Send the first invite.
    4. Both listeners fire, sending one valid "accept" response and one that
       gets dropped.
    4. Send the second invite. There are no listeners, and the test hangs.
    
    This commit changes `invite`. Now, it works like this:
    
    1. Generate an invite ID.
    2. Tell the invitee(s) to accept any invite with that ID.
    3. Send the invite.
    
    As far as I know, this isn't a problem today. But an [upcoming test
    change][1] causes this to happen much more reliably, so I think this is
    worth fixing. (I think it's worth fixing even without that upcoming
    change. Also, I tested this with those changes and it does, indeed, fix
    hung tests.)
    
    [0]: https://github.com/digidem/comapeo-core/blob/d2e5590aa749b690e5c07c3b64791db5e403ee29/test-e2e/sync.js#L530
    [1]: #856
    EvanHahn committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    1b03ac0 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Configuration menu
    Copy the full SHA
    8f7f94f View commit details
    Browse the repository at this point in the history