test: be more exact when waiting for peers #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`waitForPeers`, a test helper, currently checks that the *number* of connected peers is expected. This has two problems: - If the number of connected peers is *more than needed*, it will never resolve. - If the *number* of connected peers is correct but the actual peers are different, the promise could resolve prematurely. This snippet highlights the problem: ```javascript const managers = await createManagers(3, t) const [a, b, c] = managers connectPeers(managers) await waitForPeers([a, c]) ``` I think this is a useful change on its own, but will also make [an upcoming change][0] easier. [0]: #865
tomasciccola
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
waitForPeers, a test helper, currently checks that the number of connected peers is expected. This has two problems:This snippet highlights the problem:
I think this is a useful change on its own, but will also make an upcoming change easier.