chore: fix release workflow to run when using workflow dispatch #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe check in the other direction - the merged check is only relevant if the event is PR closed. |
mind clarifying? not entirely sure what the suggestion is. I'm taking it to mean switching the order of the checks (see 417c5c9), which could be a complete misinterpretation of your suggestion 😄 |
gmaclennan
reviewed
Sep 26, 2024
Co-authored-by: Gregor MacLennan <[email protected]>
EvanHahn
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue introduced by #854 so that the workflow runs when using the manual workflow dispatch approach.