Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Preview Label #413

Open
3 of 4 tasks
ximenabb opened this issue Jun 14, 2024 · 2 comments
Open
3 of 4 tasks

Sync Preview Label #413

ximenabb opened this issue Jun 14, 2024 · 2 comments
Assignees

Comments

@ximenabb
Copy link
Contributor

ximenabb commented Jun 14, 2024

Project Settings / Sync Settings

There are 3 states :
1- Default state : only full size available = no label since its the usual Mapeo state
2- If user clicked on Sync Everything = app will display a label on the media, mentioning it is a mix of Full size and previews
3- If user clicked on Sync Preview (Photos only), app will display a label on the media, mentioning it is a Previews only

Todo

SYNC EVERYTHING
3

  • On the observation,, display label as designed Full size and preview available on top of the media.
  • When the media is opened,, display label as designed Full size and preview available at the bottom left of the media.

SYNC PREVIEW

4
6

  • On the observation,, display label as designed Only previews are available on top of the media.
  • When the media is opened,, display label as designed Only preview is available at the bottom left of the media.

Design

https://www.figma.com/design/iUeC0Qzhb4H0unuPfxQAsM/(Mobile)-CoMapeo?node-id=590-1313&t=S0JLYvUOE79xGpF0-0

@achou11
Copy link
Member

achou11 commented Sep 5, 2024

There are 3 states :
1- Default state : only full size available = no label since its the usual Mapeo state
2- If user clicked on Sync Everything = app will display a label on the media, mentioning it is a mix of Full size and previews
3- If user clicked on Sync Preview (Photos only), app will display a label on the media, mentioning it is a Previews only

the description of these states is misleading and confusing to me. from what i gather in the designs, the states are based on the availability of the media, not the setting that's selected in the app (the setting in the app determines what's eventually available, but that's not the same).

My understanding of the different states is as follows:

  1. If only full size is available, don't show the label
  2. If both full size and previews are available, show the label mentioning both
  3. If only previews are available, show the label mentioning previews

@ErikSin
Copy link
Contributor

ErikSin commented Sep 24, 2024

@cimigree I just spoke to Ximena, and we realized that this was worded confusingly/wrong. There is no 3rd default state. There are 2 states:

  1. Sync Everything
  2. Sync Preview

and the default state is Sync Preview

I also think that andrew is correct, and that the label should be based on what media is available (not based on the sync setting state)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants