Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: sync preview label #661

Closed
wants to merge 35 commits into from
Closed

feature: sync preview label #661

wants to merge 35 commits into from

Conversation

cimigree
Copy link
Contributor

@cimigree cimigree commented Sep 5, 2024 •
edited
Loading

closes #413

Description

  • Alters the sync setting to include a default, which seems to be what is required by the issue
  • No label if the user has not selected a sync setting
  • Creates a media label component that uses the sync setting and then renders the required text depending on props passed so that it can match the requirements of the component
  • Renders the media label from the Observation and from the PhotoPreviewModal
  • I did not add the feature flag because the default is to show nothing, but let me know if that is incorrect

Screen shots

@cimigree
Starts to add sync settings screen.
9b90d9e
@cimigree
Messages.
08f15c3
@cimigree
Merges with develop
0ba4f20
@cimigree
Styles sync settings screen.
7cfd8e8
@cimigree
Merges with develop
086e631
@cimigree
Adds bold
bcfee3b
@cimigree
Messages
8a05e88
@cimigree
Merges with develop
8931da1
@cimigree
Adds the bottom sheet modals.
e8bb678
@cimigree
Adds confirmation to persisted settings. Messages
2c2c4f5
@cimigree
Consolidates the bottom sheet modal.
9015640
@cimigree
Adds an env variable to use as a feature flag.
042be70
@cimigree
Merge branch 'develop' into chore/sync-data-selector
7df5f5b
@cimigree
Changes default
58e5dfe
@cimigree
Adds media label to observation.
d052445
@cimigree
Changes as suggested by PR review.
0991449
@cimigree
Merge branch 'chore/sync-data-selector' into feature/sync-preview-label
301a1a7
@cimigree
Messages.
09c62c2
@cimigree
Merge branch 'develop' into feature/sync-preview-label
2cf1e26
@cimigree
Adds default as a choice for sync settings. Adds the media label comp…
234eb59 
…onent. Uses the media label component in the observation and the photo preview.
@cimigree
Messages
76ee3ce
@cimigree
Removes extra messages.
ebe671e
@cimigree
Updates messages
5ccdfa0
@cimigree
Adds feature flag
745bedc
@cimigree cimigree closed this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achou11 achou11 Awaiting requested review from achou11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sync Preview Label
1 participant
@cimigree