chore: add function to generate some of the metrics report #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanHahn
commented
Apr 18, 2024
| @@ -0,0 +1,29 @@ | |||
| import borders from '@osm_borders/maritime_10000m'; | |||
There was a problem hiding this comment.
This data is accurate within 10 kilometers. There are other choices with higher resolution but (1) this is small and therefore the best for performance1 (2) high accuracy might violate user privacy.
Footnotes
-
I assume ↩
|
|
||
| const {features} = lookup.getContainers({ | ||
| type: 'Point', | ||
| coordinates: [longitude, latitude], |
There was a problem hiding this comment.
I thought this was backwards, but I believe it's right (and this function is unit tested).
| import type {Observation} from '@mapeo/schema'; | ||
| import positionToCountries from './positionToCountries'; | ||
|
|
||
| export default function generateMetricsReport({ |
There was a problem hiding this comment.
This function takes a bunch of dependencies. It's more verbose, but I think it has some advantages:
- Easier to port to Electron in the future.
- Clearer to the caller what goes in; data isn't pulled from anywhere unexpected.
- Easier to test.
This was referenced Apr 22, 2024
ErikSin
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recommend reviewing this one commit at a time.
This introduces a (dormant) function for generating metrics reports. It returns a result like this:
{ "type": "metrics-v1", "appVersion": "0.0.1", "os": "android", "osVersion": 10, "screen": { "width": 1024, "height": 768 }, "countries": ["CAN", "USA", "MEX"] }This isn't all the metrics we want to collect but I think it's a useful starting point.
Closes #269 and #270.