feat: adds ability to add an audio recording #757
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction to clear the audio state for new recordings.
|
This PR is pretty large and covers alot of things. Can we break this up? Possibly into:
|
@achou11 is that your preference as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #360
Used some old pull requests
this one from SWM
And this one from @achou11
Here are the designs
And added some new code and various adjustments as needed to get things to work
I know the PermissionAudio looks messy but it was the only way I could get all of that to work smoothly. If you have other suggestions for that file, please make sure you test out the solutions you propose...
I am saving as mp4. Not sure if that is correct. Just took a guess based on what SWM had.
Not sure what properties we wanted on the audio recordings. Using those from SWM.
Make sure to add this to your env file: EXPO_PUBLIC_FEATURE_AUDIO=true
Here is a video of the happy path...