feat: adds creation, saving and playback of audio #762
Conversation
…avigation and dummy screen.
cimigree
changed the title
cimigree
changed the title
|
@ErikSin Ready for continuation of review. I changed the multi ternary to an if statement. I find it a little more readable. I moved the createdAt to happen when the recording is saved. I had to keep the header in RecordingIdle because it is needed when you go to record another audio recording after you have recorded the first one. Got rid of the unlink function because resetting seems to do the trick upon deletion as you noticed. |
src/frontend/screens/Audio/CreateRecording/useAutoStopRecording.ts
Outdated
Show resolved
Hide resolved
| .then(({sound, status}) => { | ||
| if ('error' in status && status.error) { | ||
| console.error('Error while creating audio playback', status.error); | ||
| return; | ||
| } |
There was a problem hiding this comment.
as a follow up pr, i think we should handle audio errors (because we do not handle them in the UI at all)
… modals to the RecordingDone component.
…cation. Adjusts playback location. Removes isready in state.
Hm. I can't figure out why that would be, can't replicate. Here is what it looks like on my Pixel. Is this what you are talking about? deletionvideo.mp4 |
yeah, i can recreate it sometimes....im just trying to figure out why its only happening sometimes |
cimigree
changed the title
…comapeo-mobile into feat/add-audio-save-playback
src/frontend/screens/Audio/PermissionAudioBottomSheetContent.tsx
Outdated
Show resolved
Hide resolved
src/frontend/screens/Audio/index.tsx
Outdated
| @@ -6,6 +6,8 @@ import {CustomHeaderLeft} from '../../sharedComponents/CustomHeaderLeft'; | |||
| import {StatusBar} from 'expo-status-bar'; | |||
There was a problem hiding this comment.
this StatusBar is causing a flicker in the screen when you navigate back. Notice in the video how the screen jumps up and down when navigating between the screen. I think we can just get rid of it completely. I also think that Audio/CreateRecording/index should become the new Audio/index
Screen.Recording.2024-10-08.at.8.56.54.AM.mov
There was a problem hiding this comment.
@ErikSin, There is going to be something else in Audio/index in the next PR related to Playback from the Observation. Is it ok if I leave it as is? Not the Status Bar... Having the two files
closes #360
Description
Adds the ability to create an audio file from an observation
Adds the necessary files and logic so that when you hit "stop" on an audio recording, you are given the Playback option to be able to hear what you just recorded.
Continues to address issue #360
Used this PR that Andrew created
Here are the designs
Uses some code from SWM
Instructions
Make sure to add this to your env file: EXPO_PUBLIC_FEATURE_AUDIO=true
Go to create an observation
Hit the microphone
Grant permission to record audio
You will be taken to the create audio recording screen
Watch the screen change color and the time pass and the countdown change.
It will stop automatically at 5 minutes
Hit the stop button to stop recording.
You can play, stop, play, stop, and then when you get to the end it resets to the beginning. Hope that is right. Designs weren't clear.
At that point, the audio is added to state.
You can delete it with the trashcan.
If you hit the X in the top left, the audio is added to the draft observation, the success modal opens, and you are given the option to return to the editor or record another audio, which I wired up to work.
Once you save the Observation, the audio file or files is added to the observation.
You can't see these yet... That will be another PR!