chore: update core and ipc to v2.0.0 #796
Conversation
src/backend/package-lock.json
Outdated
There was a problem hiding this comment.
confirming that the hypercore version does not unexpectedly change here (cd src/backend && npm list hypercore):
[email protected] /Users/andrewchou/GitHub/digidem/comapeo-mobile/src/backend
└─┬ @comapeo/[email protected]
├─┬ [email protected]
│ └── [email protected] deduped
└── [email protected]There was a problem hiding this comment.
No longer needed since updated core includes this (see digidem/comapeo-core@d4b9904)
There was a problem hiding this comment.
no longer needed since updated core removes support for the static maps approach, which relied on using asar files (see digidem/comapeo-core@f21a675#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L157)
achou11
force-pushed
the
ac/update-core-2.0.0
branch
from
a77242c
to
7c77942
Compare
| }) { | ||
| log('Starting app...') | ||
| log(`Device version is ${version}`) | ||
|
|
||
| const privateStorageDir = rnBridge.app.datadir() | ||
| const dbDir = join(privateStorageDir, DB_DIR_NAME) | ||
| const indexDir = join(privateStorageDir, CORE_STORAGE_DIR_NAME) | ||
| const staticStylesDir = join(sharedStoragePath, 'styles') |
There was a problem hiding this comment.
the removal of this means that devices that have installed the app previously will have a lingering directory, which shouldn't be a problem but might be something worth documenting somehow?
| "@dev-plugins/react-navigation": "^0.0.6", | ||
| "@dr.pogodin/react-native-fs": "^2.24.1", |
There was a problem hiding this comment.
no longer used at all given the removal of the external shared directory path
| @@ -56,49 +50,27 @@ process.on('exit', (code) => { | |||
| * @param {string} [options.version] Device Version | |||
| * @param {Buffer} options.rootKey | |||
| * @param {string} options.migrationsFolderPath | |||
| * @param {string} options.sharedStoragePath Path to app-specific external file storage folder | |||
There was a problem hiding this comment.
we no longer need this option because we're strictly going to use the app's "internal" storage - AKA the document directory - to store the custom maps. The path to this directory is already available via nodejs-mobile e.g. const privateStorageDir = rnBridge.app.datadir()
The setup for this will be done in the other PR
Towards #622, #623, and #624
@comapeo/coreand@comapeo/ipcto2.0.0.MapeoManageritself.Online default style:
Offline fallback: