-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add Detox e2e tests & BrowserStack CI #808
Draft
gmaclennan
wants to merge
34
commits into
develop
Choose a base branch
from
chore/add-detox-local
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… behavior in detoxrc to work on github workflow.
… NDK (Native Development Kit) required by the react-native-mmkv module for native code compilation.
…fail... experimenting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds e2e tests using Detox, plus CI integration with BrowserStack for running tests on real devices.
Unfortunately, right now it's not possible to run the app with any permissions (camera and location) enabled in BrowserStack testing. When testing locally, Detox installs the APK via
adb install -g
. The-g
argument causes the app to be installed with all the permissions already enabled. When running Detox tests on BrowserStack, BrowserStack uses their own mechanism to install the APK, and does not expose an ADB connection.Using Detox tests, there is no way to respond to a permission dialog in tests, because Detox uses gray box testing.
As a temporary fix, this PR introduces a
EXPO_PUBLIC_IS_E2E
environment variable, which is set when building for detox. If this variable is set, then the app does not ask for permissions.This means that all components in the app will be in the "no permissions granted" state.