Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix invalid fields #40

Merged
merged 4 commits into from
Apr 17, 2024
Merged

chore: fix invalid fields #40

merged 4 commits into from
Apr 17, 2024

Conversation

tomasciccola
Copy link
Contributor

@tomasciccola tomasciccola commented Apr 8, 2024 •
edited
Loading

should close #39 , need this PR and this PR merged first (with also updating the settings-builder version here)

@tomasciccola tomasciccola changed the title chore: fix building-type and name fields chore: fix invalid fields Apr 9, 2024
@tomasciccola
Copy link
Contributor Author

tomasciccola commented Apr 9, 2024 •
edited
Loading

There may be additional properties to fix. For now, key in fields is renamed tagKey, but this discussion can bring further changes

@tomasciccola tomasciccola mentioned this pull request Apr 11, 2024
Closed
4 tasks
@tomasciccola tomasciccola mentioned this pull request Apr 11, 2024
Closed
4 tasks
@tomasciccola tomasciccola merged commit 6741588 into main Apr 17, 2024
4 checks passed
@tomasciccola tomasciccola deleted the chore/fixInvalidFields branch April 17, 2024 16:09
gmaclennan added a commit that referenced this pull request Apr 18, 2024
@gmaclennan
Merge branch 'main' into node20
ac5d4c9 
* main:
  chore: add release workflow (#42)
  chore: add node_modules to gitignore (#44)
  chore: fix invalid fields (#40)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvanHahn EvanHahn EvanHahn approved these changes

@gmaclennan gmaclennan Awaiting requested review from gmaclennan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix building-type and name field
2 participants
@tomasciccola @EvanHahn