chore: use Node 20 #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This required updating the npm lockfile and CI.
|
Have you tried building the config with node 20? I think we freeze it at 12 because there's some puppeteer related things on |
|
Also I think there's a false positive on the CI. The |
|
yes, unfortunately the builder currently relies on Mapnik, and only works in Node 12. |
|
actually reading through the logs it looks like this is actually working, but it doesn't work on my machine (MacOS M1), so I think the errors might be due to mapnik not building on Apple Silicon, rather than node version. |
|
I'm thinking maybe to keep this on node12 for now, for the convenience of building locally for users with macOS |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required updating the npm lockfile.
We may want to do additional work in the future (e.g., testing on different Node versions), but I think this is worth doing now.