Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] fix mapbox token issue #757

Closed
wants to merge 4 commits into from

Conversation

achou11
Copy link
Member

@achou11 achou11 commented May 8, 2024

Addresses #756

Making this a draft so that it doesn't accidentally get merged. PR is just for easier reviewing

Note that this branches off the latest released tag (v5.6.2).

After review, I can squash down the atomic commits and create a tagged commit on this branch to trigger the publishing flow.

Notes:

  • a .env file containing a MAPBOX_ACCESS_TOKEN entry is now necessary for local development

  • the setup for reading the token is quite convoluted because of the nature of the file that holds that value. I added a lengthy comment where appropriate to provide proper details, which stem from the murky boundary between renderer and main process code in Electron.

  • I've added a secret to this repository called MAPBOX_ACCESS_TOKEN that holds the new token

  • disables autoupdate publishing for S3 (see Autoupdater is not working when trying to install 5.6.2 #750 for more context)

  • updates the development node version to v14 to fix issues with running the electron-builder cli (mainly needed for testing/debugging). we use node v14 for CI so i figured this should be okay to do, despite our Electron version running v12

@achou11
Copy link
Member Author

achou11 commented May 9, 2024

do i need to disable any signing/notarization steps in the electron-build configuration?

Copy link
Member

@gmaclennan gmaclennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok to me. Let me know when you want to coordinate the release.

@achou11
Copy link
Member Author

achou11 commented May 14, 2024

Closing this since release tag has been pushed now

@achou11 achou11 closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants