feat: add additional metadata #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
fileVersionandbuildDatetometadata.json.We're not tracking how
fileVersionchanges over time, but maybe there's a simple way to do it (for now its just a constant onscripts/build_lint.js.Additionally, there's no types nor tests in this repo.
So I think all stuff related to guarantees should be addressed in the future with a more thorough refactor of this project.
For example, in the project we validate
FieldsandPresetswith@mapeo/schema. We could do the same with the metadata maybe but with some caveats (sinceimportDateshouldn't exist before importing the config into an actual project...)