Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: close storages on close #20

Merged
merged 4 commits into from
Nov 16, 2023
Merged

fix: close storages on close #20

merged 4 commits into from
Nov 16, 2023

Conversation

gmaclennan
Copy link
Member

fixes #19

@gmaclennan gmaclennan self-assigned this Nov 15, 2023
@gmaclennan gmaclennan marked this pull request as ready for review November 15, 2023 01:52
tomasciccola
tomasciccola approved these changes Nov 15, 2023
View reviewed changes
Copy link

@tomasciccola tomasciccola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! I would never get that promisify(storage.close.bind(storage)) right

@gmaclennan gmaclennan merged commit aa4d34e into main Nov 16, 2023
3 checks passed
@gmaclennan gmaclennan deleted the fix--close-storages-on-close branch November 16, 2023 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasciccola tomasciccola tomasciccola approved these changes

Assignees

@gmaclennan gmaclennan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

take care of closing storage
2 participants
@gmaclennan @tomasciccola