Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: reject if closed state is incorrect #42

Merged
merged 4 commits into from
Apr 15, 2024
Merged

feat: reject if closed state is incorrect #42

merged 4 commits into from
Apr 15, 2024

Commits on Apr 5, 2024

  1. feat: reject if closed state is incorrect 

    Some methods, like `addCore()`, now throw if called after calling
`close()`. `unlink()` is the opposite, and should only be called after
the indexer is closed.

This is arguably a breaking change, but I feel that changing undefined
behavior is not breaking.
    @EvanHahn
    EvanHahn committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    c7bb6ee View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. Double-closing is a no-op

    @EvanHahn
    EvanHahn committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    56564f6 View commit details
    Browse the repository at this point in the history

  2. Fix code coverage for ExhaustivenessError

    @EvanHahn
    EvanHahn committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    bc566d8 View commit details
    Browse the repository at this point in the history

  3. Update docs for .close()

    @EvanHahn
    EvanHahn committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    d32e778 View commit details
    Browse the repository at this point in the history