feat!: new ReaderWatch class for handling deleted or replaced files #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING: this removes the `lazy = true` option which was adding complexity / overhead and is not useful / called for at this time.
gmaclennan
force-pushed
the
feat/watch-file-changes
branch
from
e85aa08
to
2a2c56f
Compare
* main: feat!: Remove lazy option for server (#30)
gmaclennan
changed the title
gmaclennan
changed the title
gmaclennan
changed the title
achou11
approved these changes
Oct 17, 2024
achou11
reviewed
Oct 17, 2024
There was a problem hiding this comment.
one thing that's a nice-to-have here is making sure that registering with a prefix works properly. Thought there used to be tests for that but maybe they got lost with the recent changes?
Not blocking and can do as a follow-up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING: you can no longer start the server with a filepath that does not point to a valid SMP file. If you want this functionality, use the new
ReaderWatchclass and pass an instance of that to the server.The
ReaderWatchclass will watch the given filepath to see if the file is deleted or replaced. Pass an instance ofReaderWatchto the server to support serving a fixed filepath which may or may not have a file, and watch for if the file at the filepath changes.