Fix for #20352 #20397
Merged
Fix for #20352 #20397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbrauner-da
approved these changes
Nov 29, 2024
samuel-williams-da
deleted the
sw/fix-daml3-script-preprocessing-try-submit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #20352 the cheap way for now
Daml-script currently packed TypeMismatch errors from canton as UnknownErrors, as canton packs them as generic preprocessing errors.
IDE Ledger was not catching this error, we now pack it explicitly into Unknown so the behaviours match.
We can find a nicer solution after some discussion, for now we just want tests to pass for the Rc.