python: Full-fledged typing stub files for the Protobuf/gRPC generated code #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python: Full-fledged typing stub files for the Protobuf/gRPC generated code.
These files are now automatically generated, as opposed to the original version of these typing files, which were written by hand. I've opted not to include the code that generates this code because it's fairly complex and would make an already large set of changes even larger.
mypycontinues to successfully typecheck this code with the new typing files.There are a few bug fixes as a result of this being more systematically generated, but the majority of the changes are due to generated stubs for
daml_lf_1_14/daml_lf_1_pb2.pyi.This, in part, address #193.