Update Splice from CCI (#257)

Signed-off-by: DA Automation <[email protected]>
Co-authored-by: DA Automation <[email protected]>

.circleci/canton-scripts/check-sbt-output.sh

@@ -27,7 +27,7 @@ read_sbt_output() {
 }
 
 filter_errors() {
-  grep -i -w -e error -e severe -e warn -e warning -e exception -e critical -e fatal || true
+  grep -i -e error -e severe -e warn -e warning -e exception -e critical -e fatal || true
 }
 
 # Read ignore patterns

apps/app/src/main/scala/org/lfdecentralizedtrust/splice/console/SvAppReference.scala

@@ -399,13 +399,6 @@ class SvAppBackendReference(
       httpCommand(HttpSvAdminAppClient.GetMediatorNodeStatus())
     }
 
-  def signSynchronizerBootstrappingState(domainIdPrefix: String): Unit =
-    consoleEnvironment.run {
-      httpCommand(
-        HttpSvSoftDomainMigrationPocAppClient.SignSynchronizerBootstrappingState(domainIdPrefix)
-      )
-    }
-
   def initializeSynchronizer(domainIdPrefix: String): Unit =
     consoleEnvironment.run {
       httpCommand(HttpSvSoftDomainMigrationPocAppClient.InitializeSynchronizer(domainIdPrefix))

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/SoftDomainMigrationIntegrationTest.scala

@@ -324,11 +324,17 @@ class SoftDomainMigrationIntegrationTest
     val dsoRules = sv1Backend.getDsoInfo().dsoRules
 
     clue("Bootstrap new domain") {
-      clue("Sign bootstrapping state") {
-        val signed = env.svs.local.map { sv =>
-          Future { sv.signSynchronizerBootstrappingState(prefix) }
+      clue("Wait for signed topology state to appear") {
+        env.svs.local.map { sv =>
+          eventually() {
+            sv.participantClient.topology.domain_parameters
+              .list(filterDomain = "global-domain-new") should not be empty
+          }
         }
-        signed.foreach(_.futureValue)
+        val initialized = env.svs.local.map { sv =>
+          Future { sv.initializeSynchronizer(prefix) }
+        }
+        initialized.foreach(_.futureValue)
       }
       clue("Initialize synchronizer nodes") {
         val initialized = env.svs.local.map { sv =>

apps/sv/frontend/src/components/votes/VoteRequest.tsx

@@ -66,7 +66,7 @@ export const CreateVoteRequest: React.FC = () => {
   const [actionName, setActionName] = useState('SRARC_OffboardSv');
   const [summary, setSummary] = useState<string>('');
   const [url, setUrl] = useState<string>('');
-  const [expiration, setExpiration] = useState<Dayjs | null>(null);
+  const [expiration, setExpiration] = useState<Dayjs>(dayjs());
   const [confirmDialogOpen, setConfirmDialogOpen] = useState(false);
 
   // States related to constraints from vote requests
@@ -79,34 +79,28 @@ export const CreateVoteRequest: React.FC = () => {
   const dsoInfosQuery = useDsoInfos();
   const listVoteRequestsQuery = useListDsoRulesVoteRequests();
 
-  function getDefaultExpiration(): Dayjs {
-    switch (actionName) {
-      case 'CRARC_RemoveFutureAmuletConfigSchedule':
-      case 'CRARC_UpdateFutureAmuletConfigSchedule':
-      case 'CRARC_AddFutureAmuletConfigSchedule': {
-        return dayjs();
-      }
-      default: {
-        const microseconds =
-          parseInt(dsoInfosQuery.data?.dsoRules.payload.config.voteRequestTimeout.microseconds!) /
-          1000;
-        return dayjs().add(Math.floor(microseconds), 'milliseconds');
-      }
-    }
-  }
+  const expirationFromVoteRequestTimeout = dayjs().add(
+    Math.floor(
+      parseInt(dsoInfosQuery.data?.dsoRules.payload.config.voteRequestTimeout.microseconds!) / 1000
+    ),
+    'milliseconds'
+  );
 
   useEffect(() => {
-    setExpiration(getDefaultExpiration);
+    setExpiration(expirationFromVoteRequestTimeout);
     // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [dsoInfosQuery.isSuccess]);
+  }, [dsoInfosQuery.isInitialLoading]);
 
-  useEffect(() => {
-    setExpiration(getDefaultExpiration);
+  const handleExpirationDateChange = (newDate: Dayjs | null) => {
+    setExpiration(newDate ?? dayjs());
+  };
+
+  const handleActionNameChange = (newActionName: string) => {
     setMaxDateTimeIfAddFutureAmuletConfigSchedule(undefined);
     setUrl('');
     setSummary('');
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [actionName, setActionName]); // same than above
+    setActionName(newActionName);
+  };
 
   const actionNameOptions = [
     { name: 'Offboard Member', value: 'SRARC_OffboardSv' },
@@ -223,7 +217,6 @@ export const CreateVoteRequest: React.FC = () => {
           .then(() => setSummary(''))
           .then(() => setActionName('SRARC_OffboardSv'))
           .then(() => setAction(undefined))
-          .then(() => setExpiration(getDefaultExpiration))
           .then(() => setMaxDateTimeIfAddFutureAmuletConfigSchedule(undefined))
           .then(() => setAlertMessage({}));
       }
@@ -267,7 +260,7 @@ export const CreateVoteRequest: React.FC = () => {
                   'data-testid': 'display-actions',
                 }}
                 value={actionName}
-                onChange={e => setActionName(e.target.value)}
+                onChange={e => handleActionNameChange(e.target.value)}
               >
                 {actionNameOptions.map((actionName, index) => (
                   <option key={'action-option-' + index} value={actionName.value}>
@@ -289,7 +282,7 @@ export const CreateVoteRequest: React.FC = () => {
               minDateTime={dayjs()}
               maxDateTime={maxDateTimeIfAddFutureAmuletConfigSchedule}
               readOnly={false}
-              onChange={(newValue: Dayjs | null) => setExpiration(newValue)}
+              onChange={d => handleExpirationDateChange(d)}
               slotProps={{
                 textField: {
                   id: 'datetime-picker-vote-request-expiration',

apps/sv/src/main/openapi/sv-internal.yaml

@@ -587,22 +587,6 @@ paths:
               schema:
                 "$ref": "../../../../common/src/main/openapi/common-internal.yaml#/components/schemas/GetDsoInfoResponse"
 
-  # TODO(#13301) Replace by automation
-  /v0/synchronizer/{domain_id_prefix}/sign_bootstrapping_state:
-    post:
-      tags: [sv]
-      x-jvm-package: sv_soft_domain_migration_poc
-      operationId: "signSynchronizerBootstrappingState"
-      parameters:
-        - name: "domain_id_prefix"
-          in: path
-          required: true
-          schema:
-            type: string
-      responses:
-        "200":
-          description: ok
-
   # TODO(#13301) Replace by automation
   /v0/synchronizer/{domain_id_prefix}/initialize:
     post:

apps/sv/src/main/scala/org/lfdecentralizedtrust/splice/sv/SvApp.scala

@@ -553,7 +553,6 @@ class SvApp(
           Seq(
             new HttpSvSoftDomainMigrationPocHandler(
               dsoAutomation,
-              localSynchronizerNode,
               extraSynchronizerNodes,
               participantAdminConnection,
               config.domainMigrationId,

apps/sv/src/main/scala/org/lfdecentralizedtrust/splice/sv/admin/api/client/commands/HttpSvSoftDomainMigrationPocAppClient.scala

@@ -37,21 +37,6 @@ object HttpSvSoftDomainMigrationPocAppClient {
       )
   }
 
-  case class SignSynchronizerBootstrappingState(domainIdPrefix: String)
-      extends BaseCommand[http.SignSynchronizerBootstrappingStateResponse, Unit] {
-    override def submitRequest(
-        client: Client,
-        headers: List[HttpHeader],
-    ): EitherT[Future, Either[
-      Throwable,
-      HttpResponse,
-    ], http.SignSynchronizerBootstrappingStateResponse] =
-      client.signSynchronizerBootstrappingState(domainIdPrefix, headers = headers)
-    override def handleOk()(implicit decoder: TemplateJsonDecoder) = {
-      case http.SignSynchronizerBootstrappingStateResponse.OK => Right(())
-    }
-  }
-
   case class InitializeSynchronizer(domainIdPrefix: String)
       extends BaseCommand[http.InitializeSynchronizerResponse, Unit] {
     override def submitRequest(