Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove '--target=1.15' requirement. #867

Merged
merged 6 commits into from
Feb 4, 2025

Conversation

yangzai
Copy link
Contributor

@yangzai yangzai commented Dec 15, 2024

Update config requirement for interfaces since DAML LF 1.15 is already the default from version 2.6.0.

@yangzai yangzai requested review from a team as code owners December 15, 2024 14:57
Copy link
Contributor

@carrielaben-da carrielaben-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes

@yangzai
Copy link
Contributor Author

yangzai commented Dec 16, 2024

@carrielaben-da thanks for the feedback.

Copy link
Contributor

@paulbrauner-da paulbrauner-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@paulbrauner-da
Copy link
Contributor

Could you please rebase on top of main? I can't push to your fork.

@yangzai
Copy link
Contributor Author

yangzai commented Feb 4, 2025

@paulbrauner-da rebased.

@paulbrauner-da paulbrauner-da enabled auto-merge (squash) February 4, 2025 16:09
@yves-da yves-da self-requested a review February 4, 2025 16:15
@paulbrauner-da paulbrauner-da merged commit 1938b0e into digital-asset:main Feb 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants